Move replicated-output dedup to the Dask and Ray frontends#22394
Open
Matt711 wants to merge 3 commits intorapidsai:mainfrom
Open
Move replicated-output dedup to the Dask and Ray frontends#22394Matt711 wants to merge 3 commits intorapidsai:mainfrom
Matt711 wants to merge 3 commits intorapidsai:mainfrom
Conversation
github-actions
Bot
added
Python
madsbk
added a commit
to madsbk/cudf
that referenced
this pull request
May 7, 2026
wence-
reviewed
May 7, 2026
| collect_metadata=True, | ||
| ) | ||
| if ( | ||
| self._comm is not None |
Contributor
There was a problem hiding this comment.
Can self._comm possibly be None if we got here?
Contributor
There was a problem hiding this comment.
I think instead one should raise (like for if self._ctx is None) at the beginning of the function.
wence-
approved these changes
May 7, 2026
Contributor
|
/ok to test |
@vyasr, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
|
/ok to test b513cf4 |
Contributor
Author
|
This PR depends on #22381 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChannelMetadata.duplicated=Truenow consistently means every rank holds the data.DaskEngineandRayEngine#22381Checklist